Skip to content

feat: multi-GPU parallel session execution#9263

Open
lstein wants to merge 49 commits into
invoke-ai:mainfrom
lstein:lstein/feat/multi-gpu
Open

feat: multi-GPU parallel session execution#9263
lstein wants to merge 49 commits into
invoke-ai:mainfrom
lstein:lstein/feat/multi-gpu

Conversation

@lstein

@lstein lstein commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR adds multi-GPU parallel generation: on a machine with more than one GPU, InvokeAI runs several generation sessions concurrently — one per GPU — instead of draining the queue one job at a time. Jobs are distributed fairly across users so a single user's large batch can't monopolize every GPU while others wait.

It's controlled by a new generation_devices config setting (defaults to auto = use every available CUDA GPU). Setting it to a single device, or leaving CUDA out of the picture, preserves the previous serial behavior exactly. The choice of GPUs can also be controlled via a new section of the Settings dialogue (restart required to take effect).

Demo (turn on the sound!)

invoke-mgpu.mp4

How it works — the change is built around five small backend seams plus a frontend update, rather than per-node edits:

  • Device context (invokeai/backend/util/devices.py): a thread-local set/get/clear_session_device on TorchDevice; choose_torch_device() consults it first. This is the lynchpin — the ~79 existing call sites resolve to the worker's GPU with no per-node changes.
  • Per-device model caches (model_manager_default, model_load_default): one ModelCache per device, resolved by the current thread's device, with fan-out for clear/drop/shutdown. Model construction is serialized against VRAM moves to prevent meta-device corruption. A single global RAM budget is shared across the per-device caches, and identical CPU weights are deduplicated across devices (see RAM management below).
  • Atomic dequeue (session_queue_sqlite.dequeue): a lock makes select+claim atomic so concurrent workers never grab the same queue item.
  • Worker pool (session_processor_default): one _SessionWorker per device, each pinning torch.cuda.set_device + the session device, with its own runner and cancel event; cancellation is routed per item. Profiling is disabled when more than one worker is active.
  • Concurrency hardening: added a Lock to ObjectSerializerForwardCache and made DiskImageFileStorage thread-safe for parallel sessions.

Frontend: during parallel generation the progress display stacks one progress bar per active session (each disappears as its session finishes), and the image viewer tiles per-session progress previews when ≥2 sessions are active.

Idle-GPU text-encoder offload

When more than one generation device is configured and a GPU is idle, a session's text/prompt encoder runs on the idle GPU instead of the one running its denoise pipeline. This avoids evicting the denoise model from VRAM to make room for the encoder, and lets a cached encoder be reused across generations. Under full load (no idle GPU) behavior is unchanged. Controlled by offload_text_encoders_to_idle_gpus (default on); inspired by #9310.

  • Device-pool arbiter (backend/util/device_pool.py): GENERATION_DEVICE_POOL gives each generation device one exclusive-use lock. A native session blocking-acquires its own device's lock for the whole run; an encoder node try-borrows an idle device's lock for the duration of that node. A borrowed encoder and a native session are therefore mutually exclusive on a GPU — preventing the shared-encoder corruption that produced garbled images — and the design is deadlock-free (borrows are non-blocking; a session only ever blocks on its own device).
  • Opt-in marker: nodes declare support via @invocation(idle_gpu_offloadable=True), mirroring the existing bottleneck ClassVar. Applied to the text/prompt-encoder nodes (compel + sdxl/refiner, flux, sd3, qwen-image, anima, cogview4, flux2 klein, z-image, flux_redux). The runner re-pins the worker thread to the borrowed device for the node; conditioning is stored on the CPU so the denoiser picks it up on its own GPU afterward.

RAM management for parallel sessions

Running N sessions in parallel multiplies memory pressure, so this PR also makes the model cache parallel-aware:

  • Shared global RAM budget, clamped to a safe fraction of system RAM, so summing per-device cache sizes across GPUs can't claim ~N× RAM and drive the box into swap.
  • Cross-device weight de-duplication: when a second GPU loads a model another GPU already holds, it adopts the resident CPU weights (a meta-weight structural clone + load_state_dict(assign=True)) instead of re-reading from disk and materializing a second copy. This is loader-agnostic and now also covers GGUF models — GGMLTensor doesn't implement aten.empty_like, which previously made the largest quantized models (e.g. a Q8_0 transformer) silently re-load on every device and spike RAM; the adopted GGMLTensor shares the quantized storage, so it's one copy across devices.

Generation Devices settings refinements

A few small fixes to the Generation Devices selector and its logging:

  • Stable device numbering: the disambiguating #N suffix on identically-named GPUs is now tied to each device's cuda index (its position in the full available-device set) rather than its position in the possibly-filtered generation_devices list. Previously, disabling e.g. cuda:1 renumbered the survivors in the backend startup log (cuda:2 became #2), disagreeing with the frontend, which always labels over the full set. Now both stay consistent — cuda:2 remains #3.
  • Restart reminder: reworded the Settings caption to "Restart InvokeAI for changes to take effect." and flash that same warning as a toast on every successful change, since generation_devices only takes effect after a restart.

Related Issues / Discussions

QA Instructions

On a multi-GPU machine:

  • With default config (generation_devices: auto), enqueue a batch larger than the GPU count and confirm multiple sessions run simultaneously (one per GPU), with stacked progress bars and tiled previews in the viewer.
  • Set generation_devices: [cuda:0] and confirm generation runs serially, exactly as before this PR.
  • Set generation_devices: [cuda:0, cuda:2] and confirm only those devices are used.
  • Cancel an in-flight item and confirm only that session stops.
  • On a single-GPU / CPU / MPS machine, confirm auto resolves to the one best device and behavior is unchanged.
  • Idle-GPU offload: with ≥2 GPUs and a single running session, confirm the text encoder runs on a different (idle) GPU than the denoiser (debug log: Running ... on idle device ...), and that the denoise model is not evicted to load the encoder. Set offload_text_encoders_to_idle_gpus: false and confirm the encoder runs on the session's own GPU.
  • Parallel RAM: run several parallel sessions with the same model (ideally a GGUF/quantized one) and confirm process RAM stays bounded — the transformer/text-encoder show an Adopted shared CPU weights ... log on the second device rather than a second disk load.

New automated tests cover device routing (test_model_load_device_routing.py), dequeue concurrency (test_session_queue_dequeue_concurrency.py), device resolution (test_devices.py), the device-pool lock semantics and offload mutual-exclusion (test_device_pool.py, test_encoder_offload.py), and cross-device weight adoption incl. GGUF (test_shared_weight_adoption.py).

Merge Plan

Standard merge. No DB schema or redux migrations. Touches the session processor and model cache, so worth a careful look from those areas' owners.

The idle-GPU text-encoder offload (originally prototyped as a follow-on PR) is now included in this branch, along with the cross-device GGUF weight de-duplication that keeps parallel-session RAM bounded.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration — N/A, no slice changes
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

lstein and others added 14 commits May 31, 2026 23:26
Run one generation session per configured GPU concurrently, with a tiled
progress preview. Multi-user isolation is unchanged. Backed by five seams:

- Per-thread device context (TorchDevice.set/get/clear_session_device);
  choose_torch_device() consults it first, so all device-selecting call sites
  resolve to the calling worker's GPU with no per-node changes.
- Per-device model caches: build_model_manager builds one ModelCache per
  generation device; ModelLoadService.ram_cache resolves by current thread
  device; ram_caches fans out clear/drop/shutdown.
- Atomic concurrent dequeue: a dequeue lock makes select+claim atomic so
  concurrent workers never claim the same item (works on FIFO; round-robin
  from invoke-ai#9086 slots in later).
- Worker pool: one _SessionWorker per device, each pinning torch.cuda.set_device
  and its session device, with its own runner and cancel event; cancellation
  routes via an {item_id -> worker} lookup. Single-device installs keep the
  exact legacy single-worker behavior. Profiling disabled when >1 worker.
- New config `generation_devices`; unset = legacy single-worker mode.

Frontend: the canvas staging area already tiles per queue item; the main
ImageViewer now tracks progress per session and renders a tile grid
(ProgressImageTiles) when more than one session is active.

Also adds a lock to ObjectSerializerForwardCache for concurrent access.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test_model_load_device_routing mutated the process-wide get_config()
singleton (device = "cuda:0") to exercise the per-thread cache routing,
but never restored it. The leaked CUDA device was then picked up by a
later test (test_model_load::test_loading) via choose_torch_device(),
which crashed with "Torch not compiled with CUDA enabled" on the
CUDA-less CI runner. Add an autouse fixture to save/restore device and
clear any pinned session device.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…n_devices

Regenerate openapi.json (make frontend-openapi) and the frontend
schema.ts types (make frontend-typegen) so they include the new
generation_devices config field, fixing the openapi-checks and
typegen-checks CI jobs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`make frontend-openapi` used a bare `python` from a different environment
that emitted the CacheStats @DataClass docstring as a schema description.
CI generates the schema via `uv run`, which does not, so openapi-checks
failed on the diff. Regenerate with the uv-locked environment to drop the
stray description while keeping the generation_devices field.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…o prevent meta-device corruption

Parallel multi-GPU session workers could intermittently crash with "unrecognized
device meta" (denoise) or "Cannot copy out of meta tensor; no data!" (l2i), because
model loading relies on process-global, non-thread-safe monkey-patches.

accelerate.init_empty_weights() (used directly by the loaders and implicitly by
diffusers' default low_cpu_mem_usage=True in from_pretrained) swaps
torch.nn.Module.register_parameter globally for the duration of a load, routing every
newly-registered parameter to the meta device. The model cache's VRAM load/unload runs
nn.Module.load_state_dict(assign=True), whose assign path does setattr -> __setattr__ ->
register_parameter. When one worker's VRAM move overlapped another worker's from_pretrained,
the move's real weights got hijacked onto meta and blew up on the next .to(device).

Introduce MODEL_LOAD_LOCK, a write-preferring readers-writer lock:
- write lock = model construction (_load_and_cache, load_model_from_path), exclusive.
- read lock  = VRAM load/unload (ModelCache.lock(), repair_required_tensors_on_device).

VRAM transfers across GPUs still overlap each other; they only block while a construction
holds the write lock. The lock is always acquired before any per-cache lock to keep a
consistent order and avoid an AB-BA deadlock with the writer's make_room/put.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ions

Image.open() is lazy: it reads the header but defers pixel decoding (and
holds the file handle open) until the first .load()/.copy()/.convert(). The
opened object was cached and the same object handed to every caller, so in
multi-GPU parallel mode two session-processor worker threads could call
.copy() on it concurrently and race on the shared file handle and decoder
state. This surfaced as "broken data stream when reading image file" and
"AssertionError: self.png is not None" during inpainting with batch >1.

Force the decode (image.load()) before the object enters the cache so the
cached object is safe for concurrent reads, and guard the cache structures
(__cache / __cache_ids) with a lock since they are now mutated from multiple
threads.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The generation progress bars (under the Invoke button and the Viewer tab)
both read a single global $lastProgressEvent atom, which every session
overwrites. With parallel multi-GPU sessions this made the bar jump back
and forth between sessions.

Track progress per queue item id and render one bar per in-flight session,
stacked vertically, each removed as its session reaches a terminal state.

- stores.ts: add $progressEvents (map keyed by item_id),
  $activeProgressEvents (sorted), and set/clear helpers.
- setEventListeners.tsx: populate per-item progress on invocation_progress;
  clear per item on terminal status; clear all on connect/disconnect/queue
  cleared.
- ProgressBar.tsx: render a vertical stack of bars (one per active session)
  with a single-bar fallback for the idle / model-loading window; add
  containerProps so dockview tabs can position the stack.
- Dockview tab call sites: move positioning into containerProps.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
$progressEvents is only referenced within stores.ts (via the
$activeProgressEvents computed and the set/clear helpers), so exporting
it tripped knip's unused-exports check.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
With 4 GPUs the stacked per-session progress bars grew past the bottom
strip of the dockview tab and overlapped the "Viewer" label.

Add a fitHeightPx prop: in fit mode the stack is capped to the available
strip (10px below the ~40px tab's centered label) and the bars flex to
share it, shrinking below their natural height only once they no longer
fit. With 1-2 sessions the bars keep their familiar thin height; with 3+
they scale down to stay within the strip. The sidebar bar is unaffected
and continues to stack at natural height (it has the vertical room).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…fault

generation_devices now accepts "auto" (the new default), which expands to
every visible CUDA device — so multi-GPU parallel generation works out of
the box without manually listing devices. On GPU-less systems "auto"
resolves to the single cpu/mps device, preserving serial behavior.

- config_default.py: type is now Union[Literal["auto"], list[str]],
  default "auto"; validator accepts "auto" or a list of device strings.
- devices.py: add TorchDevice.get_generation_devices(), the single resolver
  that expands "auto", normalizes, and deduplicates.
- session_processor / model_manager: both consumers use the resolver
  instead of iterating the raw config value (which would have iterated the
  characters of the "auto" string).
- Regenerated docs/src/generated/settings.json.
- Tests for the resolver (auto-with/without-CUDA, dedup, empty).

An explicit single-device list (e.g. [cuda:0]) or an empty list opts out
of parallelism.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added api python PRs that change python files backend PRs that change backend files services PRs that change app services frontend PRs that change frontend files python-tests PRs that change python tests docs PRs that change docs labels Jun 3, 2026
@lstein lstein added the 6.14.x label Jun 3, 2026
@lstein lstein moved this to 6.14.x Theme: USER EXPERIENCE in Invoke - Community Roadmap Jun 3, 2026
- Apply ruff 0.11.2 formatting to the files flagged by `ruff format --check`.
- The new fail-fast guard in get_generation_devices() (reject a CUDA device that
  doesn't exist) made the pre-existing test_get_generation_devices_explicit_list_is_deduplicated
  fail on CPU-only CI runners, since it passes a cuda list with no CUDA present. Mock
  torch.cuda.is_available/device_count in that test (matching the existing pattern in this
  file) so it validates dedup on any runner.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@lstein lstein marked this pull request as ready for review June 26, 2026 01:53
@JPPhoto

JPPhoto commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

There are some more issues that need resolving:

  • invokeai/invokeai/backend/model_manager/load/model_cache/shared_cpu_weights.py:64

    Stale shared CPU weights can survive a model setting change and be adopted by a rebuilt per-device cache. SharedCpuWeightsStore.acquire() returns the existing canonical state dict for the same cache key. drop_model() only marks locked entries stale at invokeai/invokeai/backend/model_manager/load/model_cache/model_cache.py:1068, so their shared-store reference remains live until unlock. If another device cache reloads the same model key before that unlock, the wrapper re-points the newly built module at the old canonical tensors at invokeai/invokeai/backend/model_manager/load/model_cache/cached_model/cached_model_with_partial_load.py:61 and cached_model_only_full_load.py:52. This defeats the invalidation added for load-affecting settings in invokeai/invokeai/app/api/routers/model_manager.py:445.

    Trigger: one GPU is running a model while an admin toggles a load-affecting setting such as fp8_storage; another GPU then loads that model before the first GPU unlocks.

    Consequence: the "rebuilt" cache entry can silently use the pre-change canonical weights and keep them alive under the same key.

    To expose this issue, add a test that loads the same key into two caches sharing a SharedCpuWeightsStore, locks one entry, calls drop_model() on both caches, then puts a changed model under the same key into the unlocked cache and asserts it does not adopt the old canonical tensors.

  • invokeai/invokeai/app/api/routers/app_info.py:151

    The runtime settings API validates only the device string pattern, not the same constraints enforced at startup. UpdateAppGenerationSettingsRequest.validate_generation_devices() accepts values like ["cuda:99"] if they match the regex, and update_runtime_config() persists them at lines 219 and 226. Startup later calls TorchDevice.get_generation_devices() from the model manager path, where unavailable or out-of-range CUDA devices raise at invokeai/invokeai/backend/util/devices.py:200. Empty lists are also accepted by the request model but rejected by InvokeAIAppConfig at invokeai/invokeai/app/services/config/config_default.py:272, producing an unhandled server error instead of a 422.

    Trigger: an admin or API client PATCHes /api/v1/app/runtime_config with generation_devices: ["cuda:99"] or [].

    Consequence: the server can persist a config that fails on restart, or return a 500 for input the request schema accepted.

    To expose this issue, add a test that PATCHes out-of-range CUDA and empty-list values and asserts the API rejects them with 422 without mutating or writing config.

  • invokeai/invokeai/app/services/session_queue/session_queue_sqlite.py:235

    The PR and docs still promise per-user fairness, but dequeue remains strict priority DESC, item_id ASC. The author comment says fairness is intentionally deferred to PR 9086, but this PR's docs still say a single user's large batch cannot monopolize every GPU at invokeai/docs/src/content/docs/configuration/invokeai-yaml.mdx:119 and generated settings repeat that at invokeai/docs/src/generated/settings.json:496.

    Trigger: user A enqueues a large batch before user B at the same priority on a multi-GPU system.

    Consequence: all workers keep claiming user A's older rows until they drain, so user B can still be starved despite the user-facing claim.

    To expose this issue, add a queue test that enqueues many items for user A, then one for user B, calls dequeue() repeatedly for multiple worker slots, and asserts user B is selected before A monopolizes all slots. Otherwise hold off on the fairness claim from docs until PR 9086 is merged.

  • invokeai/docs/src/content/docs/configuration/invokeai-yaml.mdx:132

    The docs advertise generation_devices: [] as a valid serial fallback, but the config validator now rejects empty lists at invokeai/invokeai/app/services/config/config_default.py:272 and tests assert rejection in tests/app/services/config/test_config_generation_devices.py:31. The same docs also say weights are duplicated in RAM per GPU at line 144, while this PR now adds shared CPU weights to avoid that.

    Trigger: Set generation_devices: [].

    Consequence: InvokeAI rejects the config instead of starting serially as documented.

    Expected docs fix: update docs/src/content/docs/configuration/invokeai-yaml.mdx and regenerated settings copy to match the accepted values and the new shared-RAM behavior.

Three RAM fixes for multi-GPU (and one that helps single-GPU too), addressing
transient spikes to ~100% RAM and swapping during text-encode/transformer loads:

1. Cap the global RAM-cache budget at a safe fraction of system RAM. When
   max_cache_ram_gb is unset, the budget was the *sum* of the per-device cache
   heuristics, so N GPUs each claiming ~50% of RAM summed to ~N*50% and starved
   the OS. Now clamp the sum to ModelCache.calc_system_ram_headroom_bytes()
   (50% of RAM - 2GB baseline, floored at 4GB). Promote the sizing magic numbers
   to named constants shared by the per-device heuristic and the global cap.

2. Adopt already-resident CPU weights across devices at load time. When a second
   device loads a model another device already holds, deep-copy a registered
   meta-weight structural clone and assign the shared canonical weights, instead
   of re-reading the model from disk and materializing a full transient second
   copy. Loader-agnostic (one mechanism in ModelLoader, no per-loader code):
   works for diffusers, single-file checkpoint, GGUF and transformers models,
   and preserves registered hooks (e.g. fp8 layerwise-cast). Best-effort with a
   meta-tensor self-check and fallback to a normal disk load on any failure.
   Skipped on single-device installs.

3. Dequantize FLUX.2 FP8 checkpoints straight to bf16. _dequantize_fp8_weights
   materialized the whole model in float32 (~36GB for 9B) before a later cast to
   bf16; now the multiply is done in float32 but stored bf16 per-weight, so the
   model is never held in float32. Numerically identical; halves the cold-load
   transient (helps single-GPU too).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@lstein

lstein commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Lots of changes in commit 2d3802a . Previously each GPU had its own RAM cache, which meant that the same model could be loaded and stay resident twice, doubling the amount of RAM needed. These changes:

  1. De-duplicate models such that the same model is only resident once.
  2. Handles the case of the model being modified by a LoRA in one GPU session and not in the other. The RAM copy holds the canonical unmodified model and the LoRA modified version only exists transiently in VRAM of the model that needs it. Same logic applies to reference images and controlnets.
  3. I was able to test on a machine with the interesting configuration of two 48 GB VRAM GPUs and 96 GB RAM. This exposed a bunch of places where model loading was being handled inefficiently and causing RAM spikes. A variety of checks have been implemented to avoid double-loading, OOMs and thrashing.

lstein and others added 7 commits June 26, 2026 22:53
The Qwen Image VAE encode/decode invocations called model_on_device() without a
working-memory estimate, unlike every other VAE family (SD/SDXL/SD3/CogView4/FLUX).
So the model cache reserved only its small default working memory, never offloaded
a large resident transformer (the VAE weights themselves are tiny), and the VAE's
forward-pass activations then OOM'd VRAM — e.g. a ~40GB Qwen Image Edit transformer
left ~1GB free while decode needed ~5GB. Reproduces single-GPU; unrelated to the
multi-GPU RAM work.

Add estimate_vae_working_memory_qwen_image() (same per-output-pixel scaling as the
other estimators, handling the 5D Qwen latents) and pass it from both the i2l
(encode, used for reference images in Image Edit) and l2i (decode) nodes, so the
cache offloads the transformer before the VAE runs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The FLUX.2 VAE encoder's mid-block self-attention scales quadratically with the
input's spatial size, and on ROCm scaled_dot_product_attention falls back to a
materialized attention matrix. Encoding a reference image (kontext) at full size
therefore allocated ~15GB in a single attention call at 1024px — and hundreds of
GB at the 2024px reference cap — OOMing VRAM regardless of how much other model
memory was freed.

Tile the reference-image encode to bound per-tile attention. The VAE's default
tile size equals its sample_size (1024), whose per-tile attention still OOMs, so
force a 512px tile (with a matching latent tile size derived from the config).
Save/restore the VAE's tiling config since it is a shared, cached instance, so the
final image decode does not inherit these settings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ModelCache._get_vram_in_use() called torch.cuda.memory_allocated() with no device
argument, while _get_vram_available() reads memory_allocated(execution_device).
The formula relies on those two canceling. In multi-GPU mode each worker calls
torch.cuda.set_device for its own GPU, so the process-current device flips between
workers; the no-argument call can then read a different (e.g. idle) GPU's
allocation, breaking the cancellation and inflating "available" VRAM toward the
card total. The cache then believes there is room and never offloads, so VRAM
offloading effectively ignores device_working_mem_gb in multi-GPU. Single-GPU was
unaffected (current device always equals the execution device).

Query self._execution_device in both _get_vram_in_use() and the cache-state debug
log. Add a regression test asserting the per-cache execution device is used.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… decode peak

The Qwen Image VAE is a 3D-conv (video) VAE whose decode allocates large conv3d
feature maps. A ~1MP decode was measured to peak at ~17 GiB of VRAM — far above
what the generic 2200/1100 SD/FLUX constants reserved (~4.6 GiB), so the cache
concluded the decode "fit" alongside the resident 20GB transformer + 15GB text
encoder, never offloaded them, and OOMed. The offload only frees ~(working_mem -
free) bytes, so the reservation must both cover the real peak and be large enough
to trigger the offload of models the decode doesn't need.

Raise the Qwen decode/encode constants (13000/6500) to match the measured peak.
It's linear in output pixels, so it over-reserves past ~1.5MP (where the decode
can exceed the card even after offloading) — that case is covered by
force_tiled_decode.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Qwen Image latents-to-image node hardcoded vae.disable_tiling(), ignoring the
global force_tiled_decode setting that the SD/SDXL l2i node honors. Wire it up the
same way so users can opt into tiled VAE decode for very large outputs that exceed
VRAM even after the transformer/text encoder are offloaded. Off by default, so
normal-size decodes are unchanged (full-frame, no tile blending).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The preview-panel progress circle re-renders on every InvocationProgressEvent. The
parent passes a fresh progressEvent object each event, so the CircularProgress
re-rendered constantly; during the indeterminate phases (everything except
denoising) that restarted its CSS spin animation each time, which looked like the
disk flashing. (Determinate denoising was unaffected because the value genuinely
changes per step.)

Split the circle into a memoized, ref-forwarding subcomponent keyed on its visual
props (isIndeterminate, value, device label) so message-only updates no longer
re-render it and the spin animation stays continuous. The Tooltip still anchors to
it via the forwarded ref.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adds `offload_text_encoders_to_idle_gpus` (default on): when more than one
generation device is configured and a GPU is idle, a session's text/prompt
encoder runs on the idle GPU instead of the one running its denoise pipeline.
This avoids evicting the denoise model from VRAM to make room for the encoder,
and lets a cached encoder be reused across generations. Under full load (no
idle GPU) behavior is unchanged.

Mechanism:
- New GENERATION_DEVICE_POOL arbiter (backend/util/device_pool.py) with a
  per-device exclusive-use lock. A native session blocking-acquires its own
  device's lock for the whole run; an encoder node try-borrows an idle device's
  lock for the duration of the node. This makes a borrowed encoder and a native
  session mutually exclusive on a GPU -- preventing the shared-encoder
  corruption that produced garbled images -- and is deadlock-free (borrows are
  non-blocking; a session only ever blocks on its own device).
- DefaultSessionRunner re-pins the worker thread to the borrowed device for the
  whole encoder node; conditioning is stored on the CPU and the denoiser picks
  it up on its own GPU afterward.
- Nodes opt in via @invocation(idle_gpu_offloadable=True), mirroring the
  existing `bottleneck` ClassVar marker. Applied to the text/prompt encoder
  nodes (compel + sdxl/refiner, flux, sd3, qwen-image, anima, cogview4, flux2
  klein, z-image, flux_redux).

Inspired by invoke-ai#9310; supersedes it.

Tests: device-pool lock semantics, two concurrency regression tests asserting a
session and a borrow never use a GPU at the same time, the runner offload
context-manager behavior, and a marker-wiring check.

Docs: invokeai-yaml.mdx (config setting) and creating-nodes.mdx (how to support
the feature in a node).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lstein and others added 3 commits June 29, 2026 08:53
_build_meta_shell built meta placeholders with torch.empty_like, which
GGMLTensor.__torch_dispatch__ rejects (NotImplemented for aten.empty_like).
It threw on the first parameter, hit the silent except, and returned None —
so GGUF models (e.g. a Q8_0 transformer) never registered a shell and the
second GPU re-loaded the full model from disk, stacking a ~20GB transient on
the retained copy and spiking RAM to ~70%.

Fall back to a plain meta placeholder (logical shape/dtype) when empty_like
isn't implemented by a tensor subclass; verified the adopted GGMLTensor shares
the quantized storage, so it's one RAM copy across devices. Peak drops ~66→~46GB.
Log shell-build failures at debug so a future un-adoptable family is diagnosable
instead of silently double-loading.

Also restore log_memory_usage's per-cold-load RAM logging (the capture method
had no callers), slimmed to baseline→transient-peak process RAM.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The backend device summary computed the disambiguating #N suffix by
enumerating the filtered generation_devices list, so disabling a device
(e.g. cuda:1) renumbered the survivors. The frontend labels over the full
device set, so the two disagreed. Compute the suffix over all available
devices instead, keeping the label stable and consistent with the frontend.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reword the Generation Devices caption to "Restart InvokeAI for changes to
take effect." and flash that same warning as a toast on every successful
change, so the restart requirement is hard to miss.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lstein and others added 7 commits June 30, 2026 10:01
Resolves conflicts with the new migration system (invoke-ai#9319) and image
storage maintenance feature:

- Adopt main's auto-discovered migration loader; sqlite_util.py no
  longer registers migrations manually.
- Main took migration_33 (image subfolder move tables); the session_queue
  device column migration is re-authored as the repo's first dated
  graph-only migration (migration_2026_07_01_add_session_queue_device,
  depends_on migration_30) with a focused test per the new migration guide.
- Take main's calibrated Qwen VAE working-memory estimator (supersedes
  the interim constants on this branch); keep this branch's
  force_tiled_decode handling in qwen_image_latents_to_image.
- Weave main's image-move maintenance pause into the multi-GPU worker
  loop in session_processor_default.
- Keep both new settings panels in SettingsModal.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts:
#	invokeai/app/services/session_queue/session_queue_sqlite.py
… multi-GPU

When a GPU worker dequeues, prefer — among the fairness-chosen user's
equal-priority pending items — one whose models are already resident in that
device's cache. Cross-device model reloads cost tens of seconds for large
models; picking a warm item instead cuts thrash when a user queues a mix of
models.

Guardrails (from adversarial review):
- Round-robin user choice and priority tiers are never overridden; the swap
  pool is limited to the candidate's user and priority.
- The swap window is capped at AFFINITY_MAX_LOOKAHEAD past the candidate's
  item_id, bounding both cold-item deferral and per-dequeue scan cost.
- Explicitly configured session_queue_mode=FIFO opts out of reordering.
- Resident keys are snapshotted before the dequeue lock, and
  ModelCache.cached_model_keys() acquires its lock non-blockingly, so a
  long-running VRAM transfer can never stall other workers' dequeues.
- Path-keyed cache entries (load_model_from_path) are excluded so a Windows
  drive letter can't poison substring scoring.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nder transformers 5.x

The single-file Qwen2.5-VL encoder loader relied on
Qwen2_5_VLForConditionalGeneration._checkpoint_conversion_mapping to translate
ComfyUI's legacy key layout (visual.*, model.layers.*) to the modern one
(model.visual.*, model.language_model.*). transformers 5.x ships that mapping
empty — the conversion moved into from_pretrained's weight-converter machinery,
which our manual load_state_dict path bypasses — so the vision tower was left
on the meta device and loading failed with "Meta tensors remain".

Fall back to the equivalent hardcoded mapping when the class attribute is
empty or absent. Verified against qwen_2.5_vl_7b_fp8_scaled.safetensors:
loads all 8.29B params with no meta tensors remaining.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@JPPhoto

JPPhoto commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator
  • Stale shared CPU weights can still survive a load-affecting model settings change. Affected paths: invokeai/app/api/routers/model_manager.py:445, invokeai/backend/model_manager/load/model_cache/model_cache.py:1144, invokeai/backend/model_manager/load/model_cache/shared_cpu_weights.py:59, invokeai/backend/model_manager/load/model_cache/cached_model/cached_model_only_full_load.py:52, invokeai/backend/model_manager/load/model_cache/cached_model/cached_model_with_partial_load.py:61. drop_model() only marks locked entries stale, so their shared-store reference stays live until unlock. Another device cache can reload the same key before that unlock and adopt the old canonical tensors. To expose this issue, add a test that locks a shared cached model, calls drop_model() across caches, then reloads the same key in another cache with different weights/settings and asserts the new entry cannot adopt the old canonical state dict.

  • Runtime config accepts invalid generation_devices values at the API boundary. Affected paths: invokeai/app/api/routers/app_info.py:151, invokeai/app/services/config/config_default.py:276, invokeai/backend/util/devices.py:218. The route validator only checks the string pattern, so it accepts [] until later config validation and accepts syntactically valid but unavailable devices like cuda:99 until later device resolution/startup. To expose this issue, add route tests for [] and an out-of-range CUDA index under mocked CUDA availability/device count, asserting a 422 and no config-file mutation.

  • Single-user mode is documented/configured as FIFO, but default device affinity reorders it. Affected paths: invokeai/app/services/config/config_default.py:221, invokeai/app/services/session_queue/session_queue_sqlite.py:304, invokeai/app/services/session_queue/session_queue_sqlite.py:320, tests/app/services/session_queue/test_session_queue_dequeue.py:390. The config says single-user mode always uses FIFO, but default session_queue_mode="round_robin" still enables affinity, allowing a later warm item to jump ahead of an older cold item. Either preserve strict FIFO in single-user mode or update config/docs to say same-priority jobs may be reordered for device affinity.

  • Multi-GPU docs still describe invalid and stale behavior. Affected path: docs/src/content/docs/configuration/invokeai-yaml.mdx:132, docs/src/content/docs/configuration/invokeai-yaml.mdx:144. The docs say generation_devices: [] is valid, but config validation rejects empty lists. They also say model weights are duplicated in system RAM per active GPU, while this PR adds shared CPU-weight deduplication. Update the docs to match the implemented behavior.

  • Cache stats still report only the API thread's default cache. Affected paths: invokeai/app/api/routers/model_manager.py:1298, invokeai/app/services/model_load/model_load_default.py:61. get_stats() returns model_manager.load.ram_cache.stats, which resolves to the default cache for API request threads, while PR 9263 now has one cache per generation device. To expose this issue, add a test with distinct stats on two ram_caches and assert the endpoint returns aggregate or per-device stats instead of only the default cache.

  • Open question: should queue priority remain global in round-robin mode? ROUND_ROBIN_DEQUEUE_QUERY chooses each user's best pending item, then orders users by least-recently served. That means a recently served user's high-priority/prepended job can wait behind another user's lower-priority job. If that is intentional fairness behavior, document it; otherwise the query needs another priority tier above user rotation.

@JPPhoto JPPhoto left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prior comments in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.14.x api backend PRs that change backend files docs PRs that change docs frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files python-tests PRs that change python tests services PRs that change app services

Projects

Status: 6.14.x Theme: USER EXPERIENCE

Development

Successfully merging this pull request may close these issues.

3 participants